Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1413373002: [turbofan] We cannot unconditionally flatten cons strings in the JSGraph. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] We cannot unconditionally flatten cons strings in the JSGraph. It is not always safe to allocate new heap objects in the JSGraph. We might have to revisit this later once we do the canonicalization for HeapConstants. R=jarin@chromium.org BUG=chromium:545364 LOG=n Committed: https://crrev.com/d168a1e844715623e8d38cf1225a6deb3afff558 Cr-Commit-Position: refs/heads/master@{#31421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/compiler/js-graph.cc View 1 chunk +1 line, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-545364.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-20 15:23:03 UTC) #1
Jarin
lgtm. Although I would really like understand why it is bad to flatten.
5 years, 2 months ago (2015-10-20 15:27:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413373002/1
5 years, 2 months ago (2015-10-20 15:35:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 15:48:03 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 15:48:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d168a1e844715623e8d38cf1225a6deb3afff558
Cr-Commit-Position: refs/heads/master@{#31421}

Powered by Google App Engine
This is Rietveld 408576698