Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/js-graph.cc

Issue 1413373002: [turbofan] We cannot unconditionally flatten cons strings in the JSGraph. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-545364.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-graph.cc
diff --git a/src/compiler/js-graph.cc b/src/compiler/js-graph.cc
index 9db67b5f7c30126ee940e2f885ab0feb4bd087f3..a2ea092e126fb2f679372bacdc0e5b530c10d3f5 100644
--- a/src/compiler/js-graph.cc
+++ b/src/compiler/js-graph.cc
@@ -12,9 +12,7 @@ namespace internal {
namespace compiler {
Node* JSGraph::ImmovableHeapConstant(Handle<HeapObject> value) {
- if (value->IsConsString()) {
- value = String::Flatten(Handle<String>::cast(value), TENURED);
- }
+ // TODO(bmeurer): Flatten cons strings here before we canonicalize them?
return graph()->NewNode(common()->HeapConstant(value));
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-545364.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698