Issue 1413353003: Update handling of std::function objects (in this case mainly TODOs).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413353003: Update handling of std::function objects (in this case mainly TODOs). (Closed)

Created:
5 years, 2 months ago by alyssar1

Modified:
5 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@105311433

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update handling of std::function objects (in this case mainly TODOs). Should cause no behavior change. Merge internal change: 105317858 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	net/tools/quic/end_to_end_test.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/tools/quic/test_tools/quic_test_server.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1414573004 Patch 1

Dependent Patchsets:

Issue 1410733007 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ryan Hamilton

5 years, 2 months ago (2015-10-21 16:42:11 UTC) #2

lgtm. as it happens, I recently landed an internal CL which replaces these
functions with Factories.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages