Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1660)

Issue 1414573004: Introduces QuicStreamSequencerBufferInterface with one implementation. Refactor, no behavior change. (Closed)

Created:
5 years, 2 months ago by alyssar1
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduces QuicStreamSequencerBufferInterface with one implementation. Refactor, no behavior change. Write an abstract class for QuicFrameList to prepare changes of underlying data structure used to buffer received StreamFrame's in sequencer. And changed some method names for readability. Merge internal change: 105311433 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Fixing the build file (previously missing a comma) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -215 lines) Patch
M net/net.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_frame_list.h View 4 chunks +25 lines, -59 lines 0 comments Download
M net/quic/quic_frame_list.cc View 9 chunks +32 lines, -12 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 3 chunks +7 lines, -14 lines 1 comment Download
M net/quic/quic_stream_sequencer.cc View 7 chunks +25 lines, -27 lines 0 comments Download
A net/quic/quic_stream_sequencer_buffer_interface.h View 1 chunk +73 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 23 chunks +100 lines, -94 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
alyssar1
5 years, 2 months ago (2015-10-21 15:04:04 UTC) #1
Ryan Hamilton
5 years, 2 months ago (2015-10-21 16:44:52 UTC) #2
lgtm, modulo the unique_ptr. Feel free to fix in the "Final" CL if you wish.

https://codereview.chromium.org/1414573004/diff/20001/net/quic/quic_stream_se...
File net/quic/quic_stream_sequencer.h (right):

https://codereview.chromium.org/1414573004/diff/20001/net/quic/quic_stream_se...
net/quic/quic_stream_sequencer.h:115:
std::unique_ptr<QuicStreamSequencerBufferInterface> buffered_frames_;
use scoped_ptr instead of std::unique_ptr or this won't build on OS X.

We should improve the merge scripts to do s/std::unique_ptr/scoped_ptr/

Powered by Google App Engine
This is Rietveld 408576698