nt # Enter a description of the change.

nt # Enter a description of the change.
Set invocation counter to INT_MIN once a function is entered into the optimization queue, so that it does not get repeatedly triggered. Mutex on megamorphic cache lookup. Make AttachCode thread safe. Cleanups.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9a7080f473521e8f1de4fce0c659791207b6b4a

[srdjan, 2015-10-21 17:06:00]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-10-21 17:35:09]

lgtm

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/code_generat...
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:1452: // prevent recursive triggering of function
optimization.
This comment has to move down to the place where the counter is being set to 0 ?

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:1454: // Prevent from being triggered again.
Can you add a comment here that INT_MIN ensures that it would take a long time
to overflow and the background compilation would be done by then.

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:183:
thread_->isolate()->object_store()->double_class())),
maybe just isolate()->object_store()->double_class() would be shorter.

[srdjan, 2015-10-21 17:45:33]

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/code_generat...
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:1452: // prevent recursive triggering of function
optimization.
On 2015/10/21 17:35:09, siva wrote:
> This comment has to move down to the place where the counter is being set to 0
?

Done.

https://codereview.chromium.org/1413233004/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:1454: // Prevent from being triggered again.
On 2015/10/21 17:35:09, siva wrote:
> Can you add a comment here that INT_MIN ensures that it would take a long time
> to overflow and the background compilation would be done by then.

Done.

[srdjan, 2015-10-21 18:00:23]

Committed patchset #3 (id:40001) manually as
c9a7080f473521e8f1de4fce0c659791207b6b4a (presubmit successful).