runtime/vm/megamorphic_cache_table.cc - Issue 1413233004: nt # Enter a description of the change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/megamorphic_cache_table.cc

Issue 1413233004: nt # Enter a description of the change. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: c Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/megamorphic_cache_table.cc

diff --git a/runtime/vm/megamorphic_cache_table.cc b/runtime/vm/megamorphic_cache_table.cc

index 6393c3fecedbd544d06613f56cf6e31ad0be44b9..7f4bbec580633f3a9a196fc47f5bb4ff5bf419eb 100644

--- a/runtime/vm/megamorphic_cache_table.cc

+++ b/runtime/vm/megamorphic_cache_table.cc

@@ -15,6 +15,8 @@ namespace dart {

RawMegamorphicCache* MegamorphicCacheTable::Lookup(Isolate* isolate,

const String& name,

const Array& descriptor) {

+ // Multiple compilation threads could access this lookup.

+ MutexLocker ml(isolate->mutex());

ASSERT(name.IsSymbol());

// TODO(rmacnak): ASSERT(descriptor.IsCanonical());

« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »