Issue 141323005: Make MediaControls minimally virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141323005: Make MediaControls minimally virtual (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make MediaControls minimally virtual Only the functions which are overridden in MediaControlsAndroid need be virtual. updateStatusDisplay() didn't do anything, so it was removed. BUG=341813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166907

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -30 lines)			Patch
	M	Source/core/html/HTMLMediaElement.cpp	View	1	2 chunks	+1 line, -6 lines	0 comments	Download
	M	Source/core/html/shadow/MediaControls.h	View	1	1 chunk	+23 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Patch 3, depends on https://codereview.chromium.org/157423002/ https://codereview.chromium.org/130693008/ is all of the patches together in a trybot ...

6 years, 10 months ago (2014-02-07 13:29:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/141323005/60001

6 years, 10 months ago (2014-02-11 07:33:57 UTC) #4

Message was sent while issue was closed.

Change committed as 166907

Expand Messages | Collapse Messages