Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender.cc

Issue 1413193009: Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and TcpCubicBytesSender and replace … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106333315
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/congestion_control/tcp_cubic_sender.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender.cc b/net/quic/congestion_control/tcp_cubic_sender.cc
index 457dd2e99c5d8524c6037e3540383ad557cca922..ac114d8ef7bcf87327239944f716801dcd4e62ef 100644
--- a/net/quic/congestion_control/tcp_cubic_sender.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender.cc
@@ -23,8 +23,7 @@ namespace {
// The minimum cwnd based on RFC 3782 (TCP NewReno) for cwnd reductions on a
// fast retransmission. The cwnd after a timeout is still 1.
const QuicPacketCount kDefaultMinimumCongestionWindow = 2;
-const QuicByteCount kMaxSegmentSize = kDefaultTCPMSS;
-const QuicByteCount kMaxBurstBytes = 3 * kMaxSegmentSize;
+const QuicByteCount kMaxBurstBytes = 3 * kDefaultTCPMSS;
const float kRenoBeta = 0.7f; // Reno backoff factor.
const uint32 kDefaultNumConnections = 2; // N-connection emulation.
} // namespace
@@ -105,7 +104,7 @@ void TcpCubicSender::ResumeConnectionState(
// Make sure CWND is in appropriate range (in case of bad data).
QuicPacketCount new_congestion_window =
- bandwidth.ToBytesPerPeriod(rtt_ms) / kMaxPacketSize;
+ bandwidth.ToBytesPerPeriod(rtt_ms) / kDefaultTCPMSS;
congestion_window_ = max(min(new_congestion_window, kMaxCongestionWindow),
kMinCongestionWindowForBandwidthResumption);
}
@@ -117,7 +116,7 @@ void TcpCubicSender::SetNumEmulatedConnections(int num_connections) {
void TcpCubicSender::SetMaxCongestionWindow(
QuicByteCount max_congestion_window) {
- max_tcp_congestion_window_ = max_congestion_window / kMaxPacketSize;
+ max_tcp_congestion_window_ = max_congestion_window / kDefaultTCPMSS;
}
float TcpCubicSender::RenoBeta() const {
@@ -237,12 +236,12 @@ QuicTime::Delta TcpCubicSender::TimeUntilSend(
if (InRecovery()) {
// PRR is used when in recovery.
return prr_.TimeUntilSend(GetCongestionWindow(), bytes_in_flight,
- slowstart_threshold_ * kMaxSegmentSize);
+ slowstart_threshold_ * kDefaultTCPMSS);
}
if (GetCongestionWindow() > bytes_in_flight) {
return QuicTime::Delta::Zero();
}
- if (min4_mode_ && bytes_in_flight < 4 * kMaxSegmentSize) {
+ if (min4_mode_ && bytes_in_flight < 4 * kDefaultTCPMSS) {
return QuicTime::Delta::Zero();
}
return QuicTime::Delta::Infinite();
@@ -279,7 +278,7 @@ QuicTime::Delta TcpCubicSender::RetransmissionDelay() const {
}
QuicByteCount TcpCubicSender::GetCongestionWindow() const {
- return congestion_window_ * kMaxSegmentSize;
+ return congestion_window_ * kDefaultTCPMSS;
}
bool TcpCubicSender::InSlowStart() const {
@@ -287,7 +286,7 @@ bool TcpCubicSender::InSlowStart() const {
}
QuicByteCount TcpCubicSender::GetSlowStartThreshold() const {
- return slowstart_threshold_ * kMaxSegmentSize;
+ return slowstart_threshold_ * kDefaultTCPMSS;
}
bool TcpCubicSender::IsCwndLimited(QuicByteCount bytes_in_flight) const {
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_bytes_sender.cc ('k') | net/quic/congestion_control/tcp_cubic_sender_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698