Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_test.cc

Issue 1413193009: Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and TcpCubicBytesSender and replace … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106333315
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/tcp_cubic_sender_test.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender_test.cc b/net/quic/congestion_control/tcp_cubic_sender_test.cc
index ad19af85994b76d8afe085efaa36ce1a7e3d0d9d..3d13996e75657163a164d6ab0212722f53fcf6fc 100644
--- a/net/quic/congestion_control/tcp_cubic_sender_test.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender_test.cc
@@ -748,7 +748,7 @@ TEST_F(TcpCubicSenderTest, BandwidthResumption) {
CachedNetworkParameters cached_network_params;
const QuicPacketCount kNumberOfPackets = 123;
const int kBandwidthEstimateBytesPerSecond =
- kNumberOfPackets * kMaxPacketSize;
+ kNumberOfPackets * kDefaultTCPMSS;
cached_network_params.set_bandwidth_estimate_bytes_per_second(
kBandwidthEstimateBytesPerSecond);
cached_network_params.set_min_rtt_ms(1000);
@@ -761,12 +761,12 @@ TEST_F(TcpCubicSenderTest, BandwidthResumption) {
// Resumed CWND is limited to be in a sensible range.
cached_network_params.set_bandwidth_estimate_bytes_per_second(
- (kMaxCongestionWindow + 1) * kMaxPacketSize);
+ (kMaxCongestionWindow + 1) * kDefaultTCPMSS);
sender_->ResumeConnectionState(cached_network_params, false);
EXPECT_EQ(kMaxCongestionWindow, sender_->congestion_window());
cached_network_params.set_bandwidth_estimate_bytes_per_second(
- (kMinCongestionWindowForBandwidthResumption - 1) * kMaxPacketSize);
+ (kMinCongestionWindowForBandwidthResumption - 1) * kDefaultTCPMSS);
sender_->ResumeConnectionState(cached_network_params, false);
EXPECT_EQ(kMinCongestionWindowForBandwidthResumption,
sender_->congestion_window());
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698