Issue 1413193006: Write newlines at the end of C files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413193006: Write newlines at the end of C files. (Closed)

Created:
5 years, 2 months ago by brettw

Modified:
5 years, 2 months ago

Reviewers:
Dirk Pranke

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Write newlines at the end of C files. When Grit generates C files for converting message IDs to strings, the generated code did not have a newline at the end. This caused problems for Mac where we warn for such cases. This patch adds the missing newline so we can remove the special-case code. R=dpranke@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=4066463928d64337e6d70046aa4f18b833a2d0e3

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	grit/format/c_format.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

brettw

5 years, 2 months ago (2015-10-20 01:49:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4066463928d64337e6d70046aa4f18b833a2d0e3 (presubmit successful).