Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(43)

Issue 1413193006: Write newlines at the end of C files. (Closed)

Created:
3 years, 10 months ago by brettw
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Write newlines at the end of C files. When Grit generates C files for converting message IDs to strings, the generated code did not have a newline at the end. This caused problems for Mac where we warn for such cases. This patch adds the missing newline so we can remove the special-case code. R=dpranke@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=4066463928d64337e6d70046aa4f18b833a2d0e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M grit/format/c_format.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
brettw
3 years, 10 months ago (2015-10-20 01:42:23 UTC) #2
Dirk Pranke
lgtm
3 years, 10 months ago (2015-10-20 01:45:13 UTC) #3
brettw
3 years, 10 months ago (2015-10-20 01:49:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4066463928d64337e6d70046aa4f18b833a2d0e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698