Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413183002: [x64] Emit vmovss when AVX is enabled. (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Emit vmovss when AVX is enabled. BUG=v8:4406 LOG=N Committed: https://crrev.com/19aa5005674dd97b79250bb6c40fa24298ad3556 Cr-Commit-Position: refs/heads/master@{#31385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -5 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
ptal. Got the original testcase finally running smoothly under --prof after this patch.
5 years, 2 months ago (2015-10-19 18:26:55 UTC) #2
yurys
lgtm
5 years, 2 months ago (2015-10-19 18:53:59 UTC) #5
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-19 19:17:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413183002/1
5 years, 2 months ago (2015-10-19 20:11:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 20:35:22 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 20:35:49 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/19aa5005674dd97b79250bb6c40fa24298ad3556
Cr-Commit-Position: refs/heads/master@{#31385}

Powered by Google App Engine
This is Rietveld 408576698