Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1413163006: Revert of base: Use MADV_REMOVE instead of ftruncate to purge discardable memory segments. (Closed)

Created:
5 years, 2 months ago by reveman
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gavinp+memory_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Use MADV_REMOVE instead of ftruncate to purge discardable memory segments. (patchset #11 id:190001 of https://codereview.chromium.org/1409743002/ ) Reason for revert: Causing crashes on MacOSX: crbug.com/546642 Original issue's description: > base: Use MADV_REMOVE instead of ftruncate to purge discardable memory segments. > > This makes the discardable memory implementation use > madvise(MADV_REMOVE) to tell the kernel to free resources > associated with purged pages. This cleans up the code as > madvise - unlike ftruncate - doesn't require us to keep the > file descriptor open and it has the huge advantage that > discardable memory can be shared between a renderer and > the GPU process. > > This also works with Ashmem for which ftrunctate is not > supported. > > BUG=543633 > TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.ZeroFilledPagesAfterPurge > > Committed: https://crrev.com/dc9010e6a83e6cc0e424d482fe038d4b1c889f60 > Cr-Commit-Position: refs/heads/master@{#355391} TBR=avi@chromium.org,danakj@chromium.org,primiano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543633, 546642 Committed: https://crrev.com/fbbaf63100f5b57104ecf721e5d2ac4a6319b5bc Cr-Commit-Position: refs/heads/master@{#355585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -73 lines) Patch
M base/memory/discardable_shared_memory.h View 2 chunks +10 lines, -9 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 4 chunks +27 lines, -23 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 chunk +13 lines, -38 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
reveman
Created Revert of base: Use MADV_REMOVE instead of ftruncate to purge discardable memory segments.
5 years, 2 months ago (2015-10-22 18:12:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413163006/1
5 years, 2 months ago (2015-10-22 18:13:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 18:15:35 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 18:16:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbbaf63100f5b57104ecf721e5d2ac4a6319b5bc
Cr-Commit-Position: refs/heads/master@{#355585}

Powered by Google App Engine
This is Rietveld 408576698