Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.h

Issue 1413093007: OOPIF: Use the same uniqueName when swapping between local and remote. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Preserve uniqueName Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/FrameTree.h
diff --git a/third_party/WebKit/Source/core/page/FrameTree.h b/third_party/WebKit/Source/core/page/FrameTree.h
index 0833397b02e759f532735a86b4cb54b6db9f5880..06819ee62daf28f09217d4b287560f01285a4196 100644
--- a/third_party/WebKit/Source/core/page/FrameTree.h
+++ b/third_party/WebKit/Source/core/page/FrameTree.h
@@ -42,6 +42,11 @@ public:
// |fallbackName| is used as a source of uniqueName.
void setName(const AtomicString& name, const AtomicString& fallbackName = nullAtom);
+ // Directly assigns both the name and uniqueName. Should only be used when
+ // switching between LocalFrames and RemoteFrames for the same logical frame
+ // so that the unique name stays unique.
+ void setNameForReplacementFrame(const AtomicString& name, const AtomicString& uniqueName);
+
Frame* parent() const;
Frame* top() const;
Frame* previousSibling() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FrameTree.cpp » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698