Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Source/core/page/FrameTree.h

Issue 1413093007: OOPIF: Use the same uniqueName when swapping between local and remote. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Preserve uniqueName Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 24 matching lines...) Expand all
35 public: 35 public:
36 explicit FrameTree(Frame* thisFrame); 36 explicit FrameTree(Frame* thisFrame);
37 ~FrameTree(); 37 ~FrameTree();
38 38
39 const AtomicString& name() const { return m_name; } 39 const AtomicString& name() const { return m_name; }
40 const AtomicString& uniqueName() const { return m_uniqueName; } 40 const AtomicString& uniqueName() const { return m_uniqueName; }
41 // If |name| is not empty, |fallbackName| is ignored. Otherwise, 41 // If |name| is not empty, |fallbackName| is ignored. Otherwise,
42 // |fallbackName| is used as a source of uniqueName. 42 // |fallbackName| is used as a source of uniqueName.
43 void setName(const AtomicString& name, const AtomicString& fallbackName = nu llAtom); 43 void setName(const AtomicString& name, const AtomicString& fallbackName = nu llAtom);
44 44
45 // Directly assigns both the name and uniqueName. Should only be used when
46 // switching between LocalFrames and RemoteFrames for the same logical frame
47 // so that the unique name stays unique.
48 void setNameForReplacementFrame(const AtomicString& name, const AtomicString & uniqueName);
49
45 Frame* parent() const; 50 Frame* parent() const;
46 Frame* top() const; 51 Frame* top() const;
47 Frame* previousSibling() const; 52 Frame* previousSibling() const;
48 Frame* nextSibling() const; 53 Frame* nextSibling() const;
49 Frame* firstChild() const; 54 Frame* firstChild() const;
50 Frame* lastChild() const; 55 Frame* lastChild() const;
51 56
52 bool isDescendantOf(const Frame* ancestor) const; 57 bool isDescendantOf(const Frame* ancestor) const;
53 Frame* traversePreviousWithWrap(bool) const; 58 Frame* traversePreviousWithWrap(bool) const;
54 Frame* traverseNext(const Frame* stayWithin = nullptr) const; 59 Frame* traverseNext(const Frame* stayWithin = nullptr) const;
(...skipping 25 matching lines...) Expand all
80 }; 85 };
81 86
82 } // namespace blink 87 } // namespace blink
83 88
84 #ifndef NDEBUG 89 #ifndef NDEBUG
85 // Outside the WebCore namespace for ease of invocation from gdb. 90 // Outside the WebCore namespace for ease of invocation from gdb.
86 void showFrameTree(const blink::Frame*); 91 void showFrameTree(const blink::Frame*);
87 #endif 92 #endif
88 93
89 #endif // FrameTree_h 94 #endif // FrameTree_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FrameTree.cpp » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698