Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 14130008: Fix race condition if a pulsing bookmark button is deleted while the bookmark bubble controller is … (Closed)

Created:
7 years, 8 months ago by Avi (use Gerrit)
Modified:
7 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina, sail+watch_chromium.org
Visibility:
Public.

Description

Fix race condition if a pulsing bookmark button is deleted while the bookmark bubble controller is showing. BUG=180102 TEST=ActionBoxTest.BookmarkAPageTest reliably works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194658

Patch Set 1 #

Patch Set 2 : less crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -82 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 5 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 2 chunks +31 lines, -28 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm View 4 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 2 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
7 years, 8 months ago (2013-04-16 21:40:05 UTC) #1
Robert Sesek
LGTM
7 years, 8 months ago (2013-04-17 19:35:34 UTC) #2
Avi (use Gerrit)
7 years, 8 months ago (2013-04-17 19:42:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r194658.

Powered by Google App Engine
This is Rietveld 408576698