chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h - Issue 14130008: Fix race condition if a pulsing bookmark button is deleted while the bookmark bubble controller is …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

Issue 14130008: Fix race condition if a pulsing bookmark button is deleted while the bookmark bubble controller is … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: less crash Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

index cc3699558ed4d858cd937a6ebd1caaea69ba777d..c28fd50e30ef758d63f82b8f6e03b71e52b4c175 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h

@@ -18,7 +18,7 @@ class BookmarkNode;

// the bookmark in various ways (name, folder, etc.)

@interface BookmarkBubbleController : BaseBubbleController {

@private

- // Both weak; owned by the current browser's profile

+ // Both weak; owned by the current browser's profile.

BookmarkModel* model_; // weak

const BookmarkNode* node_; // weak

@@ -28,7 +28,7 @@ class BookmarkNode;

BOOL alreadyBookmarked_;

// Ping me when the bookmark model changes out from under us.

- scoped_ptr<BookmarkModelObserverForCocoa> bookmark_observer_;

+ scoped_ptr<BookmarkModelObserverForCocoa> bookmarkObserver_;

IBOutlet NSTextField* bigTitle_; // "Bookmark" or "Bookmark Added!"

IBOutlet NSTextField* nameTextField_;

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm » ('j') | no next file with comments »