Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

Issue 1412963004: bluetooth: android: Implement Characteristic GetIdentifier, fix Service IDs too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
index 1c2a99a55ff315135e46ae1425e142e303308be6..5286baad3b351932001c292b3c9a42771a2cfbd2 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
@@ -10,17 +10,17 @@ namespace device {
// static
scoped_ptr<BluetoothRemoteGattCharacteristicAndroid>
-BluetoothRemoteGattCharacteristicAndroid::Create() {
+BluetoothRemoteGattCharacteristicAndroid::Create(
+ const std::string& instanceId) {
return make_scoped_ptr<BluetoothRemoteGattCharacteristicAndroid>(
- new BluetoothRemoteGattCharacteristicAndroid());
+ new BluetoothRemoteGattCharacteristicAndroid(instanceId));
}
BluetoothRemoteGattCharacteristicAndroid::
~BluetoothRemoteGattCharacteristicAndroid() {}
std::string BluetoothRemoteGattCharacteristicAndroid::GetIdentifier() const {
- NOTIMPLEMENTED();
- return "";
+ return instanceId_;
}
BluetoothUUID BluetoothRemoteGattCharacteristicAndroid::GetUUID() const {
@@ -106,6 +106,7 @@ void BluetoothRemoteGattCharacteristicAndroid::WriteRemoteCharacteristic(
}
BluetoothRemoteGattCharacteristicAndroid::
- BluetoothRemoteGattCharacteristicAndroid() {}
+ BluetoothRemoteGattCharacteristicAndroid(const std::string& instanceId)
+ : instanceId_(instanceId) {}
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698