Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(644)

Issue 1412943003: Update VideoFrameType to FrameType in RTC coders. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by pbos
Modified:
1 year, 11 months ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update VideoFrameType to FrameType in RTC coders. This type is being unified in upstream webrtc. BUG=webrtc:5042 R=mcasas@chromium.org Committed: https://crrev.com/d91e7e1645170141922cb41db254c5cddc702011 Cr-Commit-Position: refs/heads/master@{#354822}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 8 (2 generated)
pbos
PTAL woo!
1 year, 11 months ago (2015-10-19 16:01:11 UTC) #1
mcasas
lgtm https://codereview.chromium.org/1412943003/diff/1/content/renderer/media/rtc_video_decoder.cc File content/renderer/media/rtc_video_decoder.cc (right): https://codereview.chromium.org/1412943003/diff/1/content/renderer/media/rtc_video_decoder.cc#newcode196 content/renderer/media/rtc_video_decoder.cc:196: if (inputImage._frameType == webrtc::kVideoFrameKey) { nit: I'd call ...
1 year, 11 months ago (2015-10-19 17:47:04 UTC) #2
pbos
On 2015/10/19 17:47:04, mcasas wrote: > lgtm > > https://codereview.chromium.org/1412943003/diff/1/content/renderer/media/rtc_video_decoder.cc > File content/renderer/media/rtc_video_decoder.cc (right): > ...
1 year, 11 months ago (2015-10-19 17:49:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412943003/1
1 year, 11 months ago (2015-10-19 17:50:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 11 months ago (2015-10-19 19:25:28 UTC) #7
commit-bot: I haz the power
1 year, 11 months ago (2015-10-19 19:26:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d91e7e1645170141922cb41db254c5cddc702011
Cr-Commit-Position: refs/heads/master@{#354822}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b