Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412933009: Update v8_external_startup_data_assets for https://codereview.chromium.org/1422793004/ (Closed)

Created:
5 years, 1 month ago by pkotwicz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update v8_external_startup_data_assets for https://codereview.chromium.org/1422793004/ BUG=chromium:547162 LOG=Y Committed: https://crrev.com/be4d1b19dfb55b12bdf19d7b02cf7344e85bfa4c Cr-Commit-Position: refs/heads/master@{#31868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pkotwicz
jochen@ can you please take a look? This CL takes in account to changes to ...
5 years, 1 month ago (2015-11-06 18:58:51 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-07 05:57:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412933009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412933009/1
5 years, 1 month ago (2015-11-08 00:50:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-08 01:44:41 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-08 01:45:00 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/be4d1b19dfb55b12bdf19d7b02cf7344e85bfa4c
Cr-Commit-Position: refs/heads/master@{#31868}

Powered by Google App Engine
This is Rietveld 408576698