Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1412923006: Add orr (register) and orr (immediate) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add orr (register) and orr (immediate) to ARM integrated assembler. Also cleans up comments about handling a rotated imm8 value. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9c08bee818e14fa266d7f13c829f6f4d2eb81485

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -12 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 6 chunks +50 lines, -5 lines 0 comments Download
M src/IceInstARM32.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/orr.ll View 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-10-29 21:03:06 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1412923006/diff/1/src/DartARM32/assembler_arm.cc File src/DartARM32/assembler_arm.cc (right): https://codereview.chromium.org/1412923006/diff/1/src/DartARM32/assembler_arm.cc#newcode286 src/DartARM32/assembler_arm.cc:286: // Moved to AssemblerARM32::mov(..FlexImm..) Change this comment like ...
5 years, 1 month ago (2015-10-29 22:21:53 UTC) #4
Karl
Committed patchset #2 (id:20001) manually as 9c08bee818e14fa266d7f13c829f6f4d2eb81485 (presubmit successful).
5 years, 1 month ago (2015-10-30 14:42:04 UTC) #5
Karl
5 years, 1 month ago (2015-10-30 14:42:26 UTC) #6
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1412923006/diff/1/src/DartARM32/assemb...
File src/DartARM32/assembler_arm.cc (right):

https://chromiumcodereview.appspot.com/1412923006/diff/1/src/DartARM32/assemb...
src/DartARM32/assembler_arm.cc:286: // Moved to AssemblerARM32::mov(..FlexImm..)
On 2015/10/29 22:21:52, stichnot wrote:
> Change this comment like you did in the .h file?

Done.

Powered by Google App Engine
This is Rietveld 408576698