Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1412893004: Rolling forward clang, hiding some warnings (Closed)

Created:
5 years, 2 months ago by Sean Klein
Modified:
5 years, 2 months ago
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rolling forward clang, hiding some warnings. tools/clang/ directory copied from Chromium's master. build/config/compiler/BUILD.gn edited manually to silence warnings. R=jamesr@chromium.org, phosek@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4fdc9529bf7f89e80efcca6c44b9aa161d34bdcb

Patch Set 1 : Updated Clang version, warning flags. Builds successfully. #

Patch Set 2 : warning_flags in same position as chromium #

Patch Set 3 : Added some untracked files which have been added by Chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3227 lines, -2421 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 chunks +18 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 3 chunks +3 lines, -2146 lines 0 comments Download
A tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h View 1 2 1 chunk +197 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp View 1 2 1 chunk +1275 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckDispatchVisitor.h View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckDispatchVisitor.cpp View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckFieldsVisitor.h View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp View 1 2 1 chunk +152 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckFinalizerVisitor.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp View 1 2 1 chunk +133 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckGCRootsVisitor.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckGCRootsVisitor.cpp View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckTraceVisitor.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CheckTraceVisitor.cpp View 1 2 1 chunk +399 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CollectVisitor.h View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/CollectVisitor.cpp View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/Config.cpp View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 3 chunks +13 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt View 1 chunk +9 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.txt View 1 chunk +7 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/clang/plugins/ChromeClassTester.h View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/clang/plugins/ChromeClassTester.cpp View 2 chunks +52 lines, -46 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 5 chunks +16 lines, -12 lines 0 comments Download
M tools/clang/plugins/Options.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/plugins/tests/overridden_methods.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/tests/overridden_methods.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/clang/plugins/tests/overridden_methods.flags View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/plugins/tests/overridden_methods.txt View 4 chunks +13 lines, -1 line 0 comments Download
M tools/clang/scripts/package.py View 4 chunks +15 lines, -2 lines 0 comments Download
M tools/clang/scripts/update.py View 16 chunks +327 lines, -76 lines 0 comments Download
M tools/clang/scripts/update.sh View 12 chunks +79 lines, -119 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sean Klein
I'm unsure if all of these changes are necessary. This is building with an updated ...
5 years, 2 months ago (2015-10-20 18:40:28 UTC) #3
Petr Hosek
lgtm
5 years, 2 months ago (2015-10-20 21:13:23 UTC) #4
Sean Klein
5 years, 2 months ago (2015-10-20 21:15:50 UTC) #6
viettrungluu
+jamesr
5 years, 2 months ago (2015-10-20 21:17:29 UTC) #8
jamesr
lgtm
5 years, 2 months ago (2015-10-20 21:26:50 UTC) #9
Sean Klein
5 years, 2 months ago (2015-10-20 21:35:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4fdc9529bf7f89e80efcca6c44b9aa161d34bdcb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698