Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1412893004: Rolling forward clang, hiding some warnings (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Added some untracked files which have been added by Chromium Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index d595dc8e6f4afdd1c1f78edb21a9c50c04e9c158..af59c1f0980142ccb3117bbc49bbc620a7fc0d7d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -939,6 +939,20 @@ if (is_clang) {
# TODO(hans): Get this cleaned up.
"-Wno-inconsistent-missing-override",
]
+
+ # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
+ # always have different versions. Certain flags may not be recognized by
+ # one version or the other.
+ if (!is_nacl) {
+ # Flags NaCl (Clang 3.7) does not recognize.
+ default_warning_flags += [
+ # TODO(smklein): Enable this, crbug.com/507717
+ "-Wno-shift-negative-value",
+
+ # TODO(smklein): Consider enabling this once not broken by third party
+ "-Wno-bitfield-width",
+ ]
+ }
}
# chromium_code ---------------------------------------------------------------
@@ -1006,7 +1020,10 @@ config("no_chromium_code") {
# off by default in some gccs but on by default in others. BSD systems do
# not support this option, since they are usually using gcc 4.2.1, which
# does not have this flag yet.
- cflags += [ "-Wno-unused-result" ]
+ cflags += [
+ "-Wno-logical-not-parentheses",
+ "-Wno-unused-result",
+ ]
}
if (is_linux || is_android) {
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698