Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1412833009: Revert of Gather more debug info for the switch away from page id for titles and state. (Closed)

Created:
5 years, 1 month ago by Charlie Reis
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Gather more debug info for the switch away from page id for titles and state. (patchset #4 id:60001 of https://codereview.chromium.org/1410543014/ ) Reason for revert: We're getting crashes for this on the 48.0.2556.0 canary (in both UpdateState and UpdateTitle). Original issue's description: > Gather more debug info for the switch away from page id for titles and state. > > This is temporary and can be reverted after we observe crashes (or none). > > BUG=369661 > TEST=Watch for crashes in UpdateState and UpdateTitle > > Committed: https://crrev.com/a67bd94373bfe81c29d2a0cfd7ae956f899eeece > Cr-Commit-Position: refs/heads/master@{#358213} TBR=avi@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/d63f6c4afe6dac95bb697062b9c95ffac88caab8 Cr-Commit-Position: refs/heads/master@{#358367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -78 lines) Patch
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +8 lines, -54 lines 0 comments Download
M content/public/common/page_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/page_state.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Created Revert of Gather more debug info for the switch away from page id for ...
5 years, 1 month ago (2015-11-06 19:01:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412833009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412833009/1
5 years, 1 month ago (2015-11-06 19:03:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 19:06:01 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 19:06:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d63f6c4afe6dac95bb697062b9c95ffac88caab8
Cr-Commit-Position: refs/heads/master@{#358367}

Powered by Google App Engine
This is Rietveld 408576698