Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 1412833009: Revert of Gather more debug info for the switch away from page id for titles and state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // media/: 139 // media/:
140 { "VideoCaptureDeviceQTKit", kSmallSize }, 140 { "VideoCaptureDeviceQTKit", kSmallSize },
141 #endif 141 #endif
142 #if defined(KASKO) 142 #if defined(KASKO)
143 { kKaskoGuid, kSmallSize }, 143 { kKaskoGuid, kSmallSize },
144 { kKaskoEquivalentGuid, kSmallSize }, 144 { kKaskoEquivalentGuid, kSmallSize },
145 #endif 145 #endif
146 { kBug464926CrashKey, kSmallSize }, 146 { kBug464926CrashKey, kSmallSize },
147 { kViewCount, kSmallSize }, 147 { kViewCount, kSmallSize },
148 { kZeroEncodeDetails, kSmallSize }, 148 { kZeroEncodeDetails, kSmallSize },
149
150 // Temporary for http://crbug.com/369661
151 { "pageid", kSmallSize },
152 { "navuniqueid", kSmallSize },
153 { "oldindex", kSmallSize },
154 { "newindex", kSmallSize },
155 { "lastcommittedindex", kSmallSize },
156 { "oldurl", kLargeSize },
157 { "newurl", kLargeSize },
158 { "updatedvalue", kLargeSize },
159 { "oldvalue", kLargeSize },
160 { "newvalue", kLargeSize },
161 // End http://crbug.com/369661
162 }; 149 };
163 150
164 // This dynamic set of keys is used for sets of key value pairs when gathering 151 // This dynamic set of keys is used for sets of key value pairs when gathering
165 // a collection of data, like command line switches or extension IDs. 152 // a collection of data, like command line switches or extension IDs.
166 std::vector<base::debug::CrashKey> keys( 153 std::vector<base::debug::CrashKey> keys(
167 fixed_keys, fixed_keys + arraysize(fixed_keys)); 154 fixed_keys, fixed_keys + arraysize(fixed_keys));
168 155
169 // Register the switches. 156 // Register the switches.
170 { 157 {
171 // The fixed_keys names are string constants. Use static storage for 158 // The fixed_keys names are string constants. Use static storage for
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 } 335 }
349 336
350 ScopedPrinterInfo::~ScopedPrinterInfo() { 337 ScopedPrinterInfo::~ScopedPrinterInfo() {
351 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 338 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
352 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 339 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
353 base::debug::ClearCrashKey(key); 340 base::debug::ClearCrashKey(key);
354 } 341 }
355 } 342 }
356 343
357 } // namespace crash_keys 344 } // namespace crash_keys
OLDNEW
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698