Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chromeos/login/auth/stub_authenticator.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Update after review. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/login/auth/stub_authenticator.cc
diff --git a/chromeos/login/auth/stub_authenticator.cc b/chromeos/login/auth/stub_authenticator.cc
index 6a183a4328a9d1eec814fd2c314ec2090555e3dd..96cb4e01a351265c15ba0d93e2f9989d092a8de4 100644
--- a/chromeos/login/auth/stub_authenticator.cc
+++ b/chromeos/login/auth/stub_authenticator.cc
@@ -38,7 +38,7 @@ void StubAuthenticator::AuthenticateToLogin(content::BrowserContext* context,
authentication_context_ = context;
// Don't compare the entire |expected_user_context_| to |user_context| because
// during non-online re-auth |user_context| does not have a gaia id.
- if (expected_user_context_.GetUserID() == user_context.GetUserID() &&
+ if (expected_user_context_.GetAccountId() == user_context.GetAccountId() &&
*expected_user_context_.GetKey() == *user_context.GetKey()) {
task_runner_->PostTask(FROM_HERE,
base::Bind(&StubAuthenticator::OnAuthSuccess, this));
@@ -57,7 +57,8 @@ void StubAuthenticator::AuthenticateToUnlock(const UserContext& user_context) {
void StubAuthenticator::LoginAsSupervisedUser(const UserContext& user_context) {
UserContext new_user_context = user_context;
- new_user_context.SetUserIDHash(user_context.GetUserID() + kUserIdHashSuffix);
+ new_user_context.SetUserIDHash(user_context.GetAccountId().GetUserEmail() +
+ kUserIdHashSuffix);
consumer_->OnAuthSuccess(new_user_context);
}
@@ -68,17 +69,17 @@ void StubAuthenticator::LoginOffTheRecord() {
void StubAuthenticator::LoginAsPublicSession(const UserContext& user_context) {
UserContext logged_in_user_context = user_context;
logged_in_user_context.SetIsUsingOAuth(false);
- logged_in_user_context.SetUserIDHash(logged_in_user_context.GetUserID() +
- kUserIdHashSuffix);
+ logged_in_user_context.SetUserIDHash(
+ logged_in_user_context.GetAccountId().GetUserEmail() + kUserIdHashSuffix);
consumer_->OnAuthSuccess(logged_in_user_context);
}
void StubAuthenticator::LoginAsKioskAccount(const std::string& app_user_id,
achuithb 2015/10/28 23:11:46 /* app_user_id */ since you are here
Alexander Alekseev 2015/10/29 02:00:42 Done.
bool use_guest_mount) {
- UserContext user_context(expected_user_context_.GetUserID());
+ UserContext user_context(expected_user_context_.GetAccountId());
user_context.SetIsUsingOAuth(false);
- user_context.SetUserIDHash(expected_user_context_.GetUserID() +
- kUserIdHashSuffix);
+ user_context.SetUserIDHash(
+ expected_user_context_.GetAccountId().GetUserEmail() + kUserIdHashSuffix);
consumer_->OnAuthSuccess(user_context);
}
@@ -86,8 +87,8 @@ void StubAuthenticator::OnAuthSuccess() {
// If we want to be more like the real thing, we could save the user ID
// in AuthenticateToLogin, but there's not much of a point.
UserContext user_context(expected_user_context_);
- user_context.SetUserIDHash(expected_user_context_.GetUserID() +
- kUserIdHashSuffix);
+ user_context.SetUserIDHash(
+ expected_user_context_.GetAccountId().GetUserEmail() + kUserIdHashSuffix);
consumer_->OnAuthSuccess(user_context);
}

Powered by Google App Engine
This is Rietveld 408576698