chromeos/login/auth/fake_extended_authenticator.cc - Issue 1412813003: This CL replaces user_manager::UserID with AccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/login/auth/fake_extended_authenticator.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names

Patch Set: Update after review. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/login/auth/extended_authenticator_impl.cc ('K') | « chromeos/login/auth/extended_authenticator_impl.cc ('k') | chromeos/login/auth/login_performer.cc » ('j') | chromeos/login/auth/stub_authenticator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/login/auth/fake_extended_authenticator.cc

diff --git a/chromeos/login/auth/fake_extended_authenticator.cc b/chromeos/login/auth/fake_extended_authenticator.cc

index 90b569bc13d4ed697405a1b8f366211caa1052ab..e57755b99fe938b21b68b57b8a8ff7e7bc093ee7 100644

--- a/chromeos/login/auth/fake_extended_authenticator.cc

+++ b/chromeos/login/auth/fake_extended_authenticator.cc

@@ -6,6 +6,7 @@

#include "base/logging.h"

#include "chromeos/login/auth/auth_status_consumer.h"

+#include "components/signin/core/account_id/account_id.h"

namespace chromeos {

@@ -37,7 +38,8 @@ void FakeExtendedAuthenticator::AuthenticateToMount(

const ResultCallback& success_callback) {

if (expected_user_context_ == context) {

UserContext reported_user_context(context);

- const std::string mount_hash = reported_user_context.GetUserID() + "-hash";

+ const std::string mount_hash =

+ reported_user_context.GetAccountId().GetUserEmail() + "-hash";

achuithb 2015/10/28 23:11:46 Is the plan to move away from using user email for

Alexander Alekseev 2015/10/29 02:00:42 Yes.

reported_user_context.SetUserIDHash(mount_hash);

if (!success_callback.is_null())

success_callback.Run(mount_hash);