chrome/browser/chromeos/login/reauth_stats.cc - Issue 1412813003: This CL replaces user_manager::UserID with AccountId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/reauth_stats.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names

Patch Set: Rebased. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/reauth_stats.h ('K') | « chrome/browser/chromeos/login/reauth_stats.h ('k') | chrome/browser/chromeos/login/saml/saml_browsertest.cc » ('j') | chrome/browser/chromeos/login/saml/saml_offline_signin_limiter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/reauth_stats.cc

diff --git a/chrome/browser/chromeos/login/reauth_stats.cc b/chrome/browser/chromeos/login/reauth_stats.cc

index f442c974f012efa6401590731e93e96e03bdffe0..2e99e74dbc94f53ca83030690ec1241c32e7d0b6 100644

--- a/chrome/browser/chromeos/login/reauth_stats.cc

+++ b/chrome/browser/chromeos/login/reauth_stats.cc

@@ -9,7 +9,7 @@

namespace chromeos {

-void RecordReauthReason(const std::string& user_id, ReauthReason reason) {

+void RecordReauthReason(const AccountId& user_id, ReauthReason reason) {

achuithb 2015/10/23 00:08:50 account_id here and below

Alexander Alekseev 2015/10/23 09:11:21 Done.

user_manager::UserManager* user_manager = user_manager::UserManager::Get();

int old_reason;

// We record only the first value, skipping everything else, except "none"

@@ -21,7 +21,7 @@ void RecordReauthReason(const std::string& user_id, ReauthReason reason) {

}

-void SendReauthReason(const std::string& user_id) {

+void SendReauthReason(const AccountId& user_id) {

user_manager::UserManager* user_manager = user_manager::UserManager::Get();

int reauth_reason;

if (user_manager->FindReauthReason(user_id, &reauth_reason) &&