Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: chrome/browser/chromeos/login/reauth_stats.cc

Issue 1412813003: This CL replaces user_manager::UserID with AccountId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@468875--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Create-AccountID-structure-part2--user_names
Patch Set: Rebased. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/reauth_stats.h" 5 #include "chrome/browser/chromeos/login/reauth_stats.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "components/user_manager/user_manager.h" 8 #include "components/user_manager/user_manager.h"
9 9
10 namespace chromeos { 10 namespace chromeos {
11 11
12 void RecordReauthReason(const std::string& user_id, ReauthReason reason) { 12 void RecordReauthReason(const AccountId& user_id, ReauthReason reason) {
achuithb 2015/10/23 00:08:50 account_id here and below
Alexander Alekseev 2015/10/23 09:11:21 Done.
13 user_manager::UserManager* user_manager = user_manager::UserManager::Get(); 13 user_manager::UserManager* user_manager = user_manager::UserManager::Get();
14 int old_reason; 14 int old_reason;
15 // We record only the first value, skipping everything else, except "none" 15 // We record only the first value, skipping everything else, except "none"
16 // value, which is used to reset the current state. 16 // value, which is used to reset the current state.
17 if (!user_manager->FindReauthReason(user_id, &old_reason) || 17 if (!user_manager->FindReauthReason(user_id, &old_reason) ||
18 (static_cast<ReauthReason>(old_reason) == ReauthReason::NONE && 18 (static_cast<ReauthReason>(old_reason) == ReauthReason::NONE &&
19 reason != ReauthReason::NONE)) { 19 reason != ReauthReason::NONE)) {
20 user_manager->UpdateReauthReason(user_id, static_cast<int>(reason)); 20 user_manager->UpdateReauthReason(user_id, static_cast<int>(reason));
21 } 21 }
22 } 22 }
23 23
24 void SendReauthReason(const std::string& user_id) { 24 void SendReauthReason(const AccountId& user_id) {
25 user_manager::UserManager* user_manager = user_manager::UserManager::Get(); 25 user_manager::UserManager* user_manager = user_manager::UserManager::Get();
26 int reauth_reason; 26 int reauth_reason;
27 if (user_manager->FindReauthReason(user_id, &reauth_reason) && 27 if (user_manager->FindReauthReason(user_id, &reauth_reason) &&
28 static_cast<ReauthReason>(reauth_reason) != ReauthReason::NONE) { 28 static_cast<ReauthReason>(reauth_reason) != ReauthReason::NONE) {
29 UMA_HISTOGRAM_ENUMERATION("Login.ReauthReason", reauth_reason, 29 UMA_HISTOGRAM_ENUMERATION("Login.ReauthReason", reauth_reason,
30 NUM_REAUTH_FLOW_REASONS); 30 NUM_REAUTH_FLOW_REASONS);
31 user_manager->UpdateReauthReason(user_id, 31 user_manager->UpdateReauthReason(user_id,
32 static_cast<int>(ReauthReason::NONE)); 32 static_cast<int>(ReauthReason::NONE));
33 } 33 }
34 } 34 }
35 35
36 } // namespace chromeos 36 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698