Issue 1412793013: Merge to XFA: Move a unique_ptr initialisation out of the initialisation list in fsdk_mgr.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412793013: Merge to XFA: Move a unique_ptr initialisation out of the initialisation list in fsdk_mgr.cpp (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Move a unique_ptr initialisation out of the initialisation list in fsdk_mgr.cpp TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1407103006 . (cherry picked from commit ef26566853fcd014f4b5c4944e480db75afc6729) Committed: https://pdfium.googlesource.com/pdfium/+/de6088db8403e775e2963ce6e0bd55e5356beb73

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	fpdfsdk/src/fsdk_mgr.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

Oliver Chang

5 years, 1 month ago (2015-10-30 23:30:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de6088db8403e775e2963ce6e0bd55e5356beb73 (presubmit successful).