Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1407103006: Move a unique_ptr initialisation out of the initialisation list in fsdk_mgr.cpp (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move a unique_ptr initialisation out of the initialisation list in fsdk_mgr.cpp R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ef26566853fcd014f4b5c4944e480db75afc6729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Oliver Chang
ptal. trivial change as discussed in previous CL.
5 years, 1 month ago (2015-10-30 23:13:48 UTC) #1
Tom Sepez
lgtm
5 years, 1 month ago (2015-10-30 23:22:52 UTC) #2
Oliver Chang
Committed patchset #1 (id:1) manually as ef26566853fcd014f4b5c4944e480db75afc6729 (presubmit successful).
5 years, 1 month ago (2015-10-30 23:24:29 UTC) #4
Tom Sepez
Just to be clear, its fine to initialize a unique pointer in the initialization list, ...
5 years, 1 month ago (2015-11-03 17:24:22 UTC) #5
Oliver Chang
5 years, 1 month ago (2015-11-03 17:27:20 UTC) #6
Message was sent while issue was closed.
On 2015/11/03 17:24:22, Tom Sepez wrote:
> Just to be clear, its fine to initialize a unique pointer in the
initialization
> list, the issue is passing this to function called from the initialization
list.

ack, the CL description probably wasn't the best. thanks.

Powered by Google App Engine
This is Rietveld 408576698