Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1412793012: Fix Python imported modules depfile generation (Closed)

Created:
5 years, 1 month ago by tsniatowski
Modified:
5 years, 1 month ago
Reviewers:
cjhopman, agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Python imported modules depfile generation Some Python scripts incorrectly reported no python module deps, for example a manual run of build/android/gn/zip.py would create an empty depfile (without even a build_utils.py entry). GetPythonDependencies assumed that CHROMIUM_SRC is an absolute path, turns out that depends on details of how build_utils.py is imported. If it happened to be relative, all modules would be omitted from the depfile as "system" modules, as they did not match CHROMIUM_SRC. Fix by using DIR_SOURCE_ROOT which is absolute (and assert that it is). R=cjhopman@chromium.org, agrieve@chromium.org BUG=359249 Committed: https://crrev.com/2e3ee5b02663f63194484fe5c4ec92c39a005617 Cr-Commit-Position: refs/heads/master@{#357246}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use constants.DIR_SOURCE_ROOT, assert isabs instead of abspath #

Patch Set 3 : Remove stray slash in os.path.join #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M build/android/gyp/jinja_template.py View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
tsniatowski
PTAL. Slightly incorrect dependencies are never fun.
5 years, 1 month ago (2015-10-29 21:38:42 UTC) #1
agrieve
https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py#newcode341 build/android/gyp/util/build_utils.py:341: abs_root = os.path.abspath(CHROMIUM_SRC) I think it'd be even better ...
5 years, 1 month ago (2015-10-30 00:11:46 UTC) #2
agrieve
https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py#newcode341 build/android/gyp/util/build_utils.py:341: abs_root = os.path.abspath(CHROMIUM_SRC) On 2015/10/30 00:11:45, agrieve wrote: > ...
5 years, 1 month ago (2015-10-30 00:25:06 UTC) #3
tsniatowski
https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py#newcode341 build/android/gyp/util/build_utils.py:341: abs_root = os.path.abspath(CHROMIUM_SRC) On 2015/10/30 00:25:06, agrieve wrote: > ...
5 years, 1 month ago (2015-10-30 00:31:21 UTC) #4
agrieve
On 2015/10/30 00:31:21, tsniatowski wrote: > https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py > File build/android/gyp/util/build_utils.py (right): > > https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py#newcode341 > ...
5 years, 1 month ago (2015-10-30 00:58:19 UTC) #5
agrieve
On 2015/10/30 00:58:19, agrieve wrote: > On 2015/10/30 00:31:21, tsniatowski wrote: > > > https://codereview.chromium.org/1412793012/diff/1/build/android/gyp/util/build_utils.py ...
5 years, 1 month ago (2015-10-30 16:06:23 UTC) #7
agrieve
On 2015/10/30 16:06:23, agrieve wrote: > On 2015/10/30 00:58:19, agrieve wrote: > > On 2015/10/30 ...
5 years, 1 month ago (2015-10-30 16:07:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412793012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412793012/20001
5 years, 1 month ago (2015-10-30 16:37:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/134450) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-10-30 16:52:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412793012/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412793012/40001
5 years, 1 month ago (2015-10-30 23:37:20 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-31 00:59:27 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-31 01:02:53 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e3ee5b02663f63194484fe5c4ec92c39a005617
Cr-Commit-Position: refs/heads/master@{#357246}

Powered by Google App Engine
This is Rietveld 408576698