Fix Python imported modules depfile generation

build/android/gyp/util/build_utils.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import contextlib
 import fnmatch
 import json
 import os
 import pipes
@@ skipping 320 matching lines @@
 def GetPythonDependencies():
   """Gets the paths of imported non-system python modules.
 
   A path is assumed to be a "system" import if it is outside of chromium's
   src/. The paths will be relative to the current directory.
   """
   module_paths = (m.__file__ for m in sys.modules.itervalues()
                   if m is not None and hasattr(m, '__file__'))
 
   abs_module_paths = map(os.path.abspath, module_paths)
+  abs_root = os.path.abspath(CHROMIUM_SRC)

[agrieve, 2015/10/30 00:11:45]

I think it'd be even better to make CHROMIUM_SRC an absolute path so that it
doesn't become invalid when the cwd changes

[agrieve, 2015/10/30 00:25:06]

Actually - almost everywhere actually uses DIR_SOURCE_ROOT from:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...

Can you delete CHROMIUM_SRC in favour of DIR_SOURCE_ROOT? Seems only this file
and build/android/gyp/jinja_template.py use it.

[tsniatowski, 2015/10/30 00:31:21]

The problem is when someone goes and changes it back to a relative path this
will silently break. I think since this function's correctness relies on
comparing absolute paths, it should explicitly make sure they are absolute.

DIR_SOURCE_ROOT seems okay too, I'll change it (tomorrow) [but personally I'd
keep the explicit abspath here, or an os.path.isabs check]

 
   non_system_module_paths = [
-      p for p in abs_module_paths if p.startswith(CHROMIUM_SRC)]
+      p for p in abs_module_paths if p.startswith(abs_root)]
   def ConvertPycToPy(s):
     if s.endswith('.pyc'):
       return s[:-1]
     return s
 
   non_system_module_paths = map(ConvertPycToPy, non_system_module_paths)
   non_system_module_paths = map(os.path.relpath, non_system_module_paths)
   return sorted(set(non_system_module_paths))
 
 
@@ skipping 91 matching lines @@
 
   md5_check.CallAndRecordIfStale(
       on_stale_md5,
       record_path=record_path,
       input_paths=input_paths,
       input_strings=input_strings,
       output_paths=output_paths,
       force=force,
       pass_changes=True)