mojo/PRESUBMIT.py - Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/PRESUBMIT.py

Issue 1412733002: C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: link sanitizer to examples/serialization (to fix the ASAN build failure) Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« examples/serialization/serialization.mojom ('K') | « examples/serialization/serialization.mojom ('k') | mojo/public/cpp/bindings/BUILD.gn » ('j') | mojo/public/cpp/bindings/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/PRESUBMIT.py

diff --git a/mojo/PRESUBMIT.py b/mojo/PRESUBMIT.py

index e770e481449ff3ced9de1e60c78e1e4f15de8c2c..c88f8e9662530af871b71f76e795b4944d52fdec 100644

--- a/mojo/PRESUBMIT.py

+++ b/mojo/PRESUBMIT.py

@@ -79,7 +79,8 @@ def _IsBuildFileWithinPackage(f, package):

if not f.LocalPath().startswith(package_path_prefix):

return False

if (not f.LocalPath().endswith("/BUILD.gn") and

- not f.LocalPath().endswith(".gni")):

+ not f.LocalPath().endswith(".gni") or

+ f.LocalPath() == "mojo/public/tools/bindings/mojom.gni"):

viettrungluu 2015/10/20 23:54:37 It seems unfortunate to hard-code this exception i

vardhan 2015/10/21 19:29:38 yeah it's kind weird, but i figured this is where

return False

if f.LocalPath() in _PACKAGE_IGNORED_BUILD_FILES[package]:

return False

« examples/serialization/serialization.mojom ('K') | « examples/serialization/serialization.mojom ('k') | mojo/public/cpp/bindings/BUILD.gn » ('j') | mojo/public/cpp/bindings/BUILD.gn » ('J')