C++ bindings: separate out serialization source set, have "mojom" targets optionally use serializat…

mojo/PRESUBMIT.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for mojo
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 61 matching lines @@
 }
 
 def _IsBuildFileWithinPackage(f, package):
   """Returns whether |f| specifies a GN build file within |package|."""
   assert package in _PACKAGE_PATH_PREFIXES
   package_path_prefix = _PACKAGE_PATH_PREFIXES[package]
 
   if not f.LocalPath().startswith(package_path_prefix):
     return False
   if (not f.LocalPath().endswith("/BUILD.gn") and
-      not f.LocalPath().endswith(".gni")):
+      not f.LocalPath().endswith(".gni") or
+      f.LocalPath() == "mojo/public/tools/bindings/mojom.gni"):

[viettrungluu, 2015/10/20 23:54:37]

It seems unfortunate to hard-code this exception into a function called
"_IsBuildFileWithinPackage()". Can't you put the exception where it's called?

[vardhan, 2015/10/21 19:29:38]

yeah it's kind weird, but i figured this is where we're deciding which gn files
we should run the presubmit on..

i'll move it to the call site.

     return False
   if f.LocalPath() in _PACKAGE_IGNORED_BUILD_FILES[package]:
     return False
   return True
 
 def _AffectedBuildFilesWithinPackage(input_api, package):
   """Returns all the affected build files within |package|."""
   return [f for f in input_api.AffectedFiles()
       if _IsBuildFileWithinPackage(f, package)]
 
@@ skipping 185 matching lines @@
 def CheckChangeOnUpload(input_api, output_api):
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(_CheckChangePylintsClean(input_api, output_api))
   return results
 
 def CheckChangeOnCommit(input_api, output_api):
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   return results