Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/platform/exported/WebString.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add a few more fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/platform/exported/WebHTTPLoadInfo.cpp ('K') | « Source/platform/exported/WebHTTPLoadInfo.cpp ('k') | Source/platform/graphics/Canvas2DLayerBridge.cpp » ('j') | Source/platform/network/HTTPRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/exported/WebString.cpp
diff --git a/Source/platform/exported/WebString.cpp b/Source/platform/exported/WebString.cpp
index 789e95d1e588daeadcbd5486ae9c240e0d6ecabd..0bc91bada19d9950b9bacab667fa84fb7f91605f 100644
--- a/Source/platform/exported/WebString.cpp
+++ b/Source/platform/exported/WebString.cpp
@@ -120,9 +120,8 @@ bool WebString::equals(const WebString& s) const
return equal(m_private.get(), s.m_private.get());
}
-WebString::WebString(const WTF::String& s)
+WebString::WebString(const WTF::String& s) : m_private(s.impl())
abarth-chromium 2014/01/17 06:59:08 ditto
{
- m_private = s.impl();
}
WebString& WebString::operator=(const WTF::String& s)
« Source/platform/exported/WebHTTPLoadInfo.cpp ('K') | « Source/platform/exported/WebHTTPLoadInfo.cpp ('k') | Source/platform/graphics/Canvas2DLayerBridge.cpp » ('j') | Source/platform/network/HTTPRequest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698