Source/core/svg/SVGAnimateMotionElement.cpp - Issue 141273002: Code problems detected by cppcheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimateMotionElement.cpp

Issue 141273002: Code problems detected by cppcheck (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a few more fixes Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAnimateMotionElement.cpp

diff --git a/Source/core/svg/SVGAnimateMotionElement.cpp b/Source/core/svg/SVGAnimateMotionElement.cpp

index 9c76b316404718f5dffa21750475903566d5ce6c..fd9012309ad207d2cc2c42c7ce071726c9b37e70 100644

--- a/Source/core/svg/SVGAnimateMotionElement.cpp

+++ b/Source/core/svg/SVGAnimateMotionElement.cpp

@@ -277,11 +277,10 @@ void SVGAnimateMotionElement::calculateAnimatedValue(float percentage, unsigned

ASSERT(!m_animationPath.isEmpty());

- bool ok = false;

float positionOnPath = m_animationPath.length() * percentage;

FloatPoint position;

float angle;

- ok = m_animationPath.pointAndNormalAtLength(positionOnPath, position, angle);

+ bool ok = m_animationPath.pointAndNormalAtLength(positionOnPath, position, angle);

if (!ok)

return;