Issue 1412633005: Add type info on created lists (fix three warnings found by DDC).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1412633005: Add type info on created lists (fix three warnings found by DDC). (Closed)

Created:
5 years, 1 month ago by devoncarew

Modified:
5 years, 1 month ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, Jennifer Messerly, vsm

Base URL:
https://github.com/dart-lang/pub_semver.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add type info on created lists (fix three warnings found by DDC). BUG=

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	lib/src/version_constraint.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/src/version_union.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

devoncarew

Fixes https://github.com/dart-lang/pub_semver/issues/10 - three strong mode warnings from DDC.

5 years, 1 month ago (2015-10-30 22:04:38 UTC) #2

nweiz

lgtm Can you add bump the pubspec up a patch version and add a CHANGELOG ...

5 years, 1 month ago (2015-10-30 22:17:47 UTC) #3

devoncarew

On 2015/10/30 22:17:47, nweiz wrote: > lgtm > > Can you add bump the pubspec ...

5 years, 1 month ago (2015-10-30 22:25:43 UTC) #4

nweiz

5 years, 1 month ago (2015-10-30 22:36:33 UTC) #5

On 2015/10/30 22:25:43, devoncarew wrote:
> On 2015/10/30 22:17:47, nweiz wrote:
> > lgtm
> > 
> > Can you add bump the pubspec up a patch version and add a CHANGELOG entry?
> 
> Yup - bumped to 1.2.2+1 (from 1.2.2).

We don't use build identifiers except on 0.x.x versions—they're basically a
replacement for patch numbers when we don't have as many digits to work with. So
this should be 1.2.3.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages