lib/src/version_union.dart - Issue 1412633005: Add type info on created lists (fix three warnings found by DDC).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/version_union.dart

Issue 1412633005: Add type info on created lists (fix three warnings found by DDC). (Closed) Base URL: https://github.com/dart-lang/pub_semver.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/src/version_union.dart

diff --git a/lib/src/version_union.dart b/lib/src/version_union.dart

index ee9f657acf6d3a7b71e1f8cfa72f3b7cf3baa025..a6715145a84223dbd839ad04ee6c4f73f430b0d5 100644

--- a/lib/src/version_union.dart

+++ b/lib/src/version_union.dart

@@ -59,7 +59,7 @@ class VersionUnion implements VersionConstraint {

(flattened as List).sort(compareMax);

- var merged = [];

+ var merged = <VersionRange>[];

for (var constraint in flattened) {

// Merge this constraint with the previous one, but only if they touch.

if (merged.isEmpty ||

@@ -132,7 +132,7 @@ class VersionUnion implements VersionConstraint {

// Because both lists of constraints are ordered by minimum version, we can

// safely move through them linearly here.

- var newConstraints = [];

+ var newConstraints = <VersionRange>[];

ourConstraints.moveNext();

theirConstraints.moveNext();

while (ourConstraints.current != null && theirConstraints.current != null) {

« no previous file with comments | « lib/src/version_constraint.dart ('k') | no next file » | no next file with comments »