Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issue 1412623007: GN: Factor "stamp" and "copy" details out of toolchains (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Factor "stamp" and "copy" details out of toolchains The "stamp" and "copy" tools are unlike all other tools in a toolchain: their definitions are entirely generic to a given host operating system, rather than depending on the exact the target of the toolchain. Use the same definitions in all toolchains, depending only on $host_os. BUG=512869 R=dpranke@chromium.org Committed: https://crrev.com/4d550a5990654c3dcfa9bbc38da3bbfa4e5c4796 Cr-Commit-Position: refs/heads/master@{#356416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +7 lines, -5 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +8 lines, -5 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +17 lines, -0 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Roland McGrath
5 years, 1 month ago (2015-10-27 21:22:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412623007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412623007/1
5 years, 1 month ago (2015-10-27 21:24:05 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 1 month ago (2015-10-27 21:24:06 UTC) #5
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-27 21:40:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412623007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412623007/1
5 years, 1 month ago (2015-10-27 22:13:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 22:37:34 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 22:38:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d550a5990654c3dcfa9bbc38da3bbfa4e5c4796
Cr-Commit-Position: refs/heads/master@{#356416}

Powered by Google App Engine
This is Rietveld 408576698