Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1412623007: GN: Factor "stamp" and "copy" details out of toolchains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/toolchain.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 81108369a544ba3c8ec5a1740f8f6164232cfec2..27b97ad9755179d009db59f5d2d1cd8be51730b1 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -13,6 +13,7 @@ declare_args() {
import("//build/config/win/visual_studio_version.gni")
import("//build/toolchain/goma.gni")
+import("//build/toolchain/toolchain.gni")
# Should only be running on Windows.
assert(is_win)
@@ -214,15 +215,16 @@ template("msvc_toolchain") {
rspfile_content = "{{inputs_newline}} {{libs}} {{solibs}} {{ldflags}}"
}
+ # These two are really entirely generic, but have to be repeated in
+ # each toolchain because GN doesn't allow a template to be used here.
+ # See //build/toolchain/toolchain.gni for details.
tool("stamp") {
- command = "$python_path gyp-win-tool stamp {{output}}"
- description = "STAMP {{output}}"
+ command = stamp_command
+ description = stamp_description
}
-
tool("copy") {
- command =
- "$python_path gyp-win-tool recursive-mirror {{source}} {{output}}"
- description = "COPY {{source}} {{output}}"
+ command = copy_command
+ description = copy_description
}
# When invoking this toolchain not as the default one, these args will be
« no previous file with comments | « build/toolchain/toolchain.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698