PNaCl. Enables Unsandboxed nonsfi ARM32.

PNaCl. Enables Unsandboxed nonsfi ARM32.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/e9ffd89a1e70ac9de8444faa9ca21f63b865fa3d

[Jim Stichnoth, 2015-10-15 23:31:40]

stichnot@chromium.org changed reviewers:
+ stichnot@chromium.org

[Jim Stichnoth, 2015-10-15 23:31:41]

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
File toolchain_build/toolchain_build_pnacl.py (right):

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
toolchain_build/toolchain_build_pnacl.py:1150: for os_name in ['linux']:
Use ('linux') like syntax above?

[Jim Stichnoth, 2015-10-31 16:21:23]

https://codereview.chromium.org/1412503002/diff/20001/toolchain_build/pnacl_t...
File toolchain_build/pnacl_targetlibs.py (right):

https://codereview.chromium.org/1412503002/diff/20001/toolchain_build/pnacl_t...
toolchain_build/pnacl_targetlibs.py:633: if arch == 'arm-linux':
elif ?

https://codereview.chromium.org/1412503002/diff/20001/toolchain_build/pnacl_t...
toolchain_build/pnacl_targetlibs.py:823: }[arch]
This fails e.g. when arch='x86-32-mac'.  Maybe this should fall back to the
empty string when the key is not present?

Same for arch_cflags.

[John, 2015-10-31 17:22:24]

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
File toolchain_build/toolchain_build_pnacl.py (right):

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
toolchain_build/toolchain_build_pnacl.py:1150: for os_name in ['linux']:
On 2015/10/15 23:31:41, stichnot wrote:
> Use ('linux') like syntax above?

Because python, ('linux') means something else:

    os_name in ('l', 'i', 'n', 'u', 'x')

https://codereview.chromium.org/1412503002/diff/20001/toolchain_build/pnacl_t...
File toolchain_build/pnacl_targetlibs.py (right):

https://codereview.chromium.org/1412503002/diff/20001/toolchain_build/pnacl_t...
toolchain_build/pnacl_targetlibs.py:633: if arch == 'arm-linux':
On 2015/10/31 16:21:23, stichnot wrote:
> elif ?

doh!

https://codereview.chromium.org/1412503002/diff/20001/toolchain_build/pnacl_t...
toolchain_build/pnacl_targetlibs.py:823: }[arch]
On 2015/10/31 16:21:23, stichnot wrote:
> This fails e.g. when arch='x86-32-mac'.  Maybe this should fall back to the
> empty string when the key is not present?
> 
> Same for arch_cflags.

Done.

[Jim Stichnoth, 2015-10-31 17:41:31]

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
File toolchain_build/toolchain_build_pnacl.py (right):

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
toolchain_build/toolchain_build_pnacl.py:1150: for os_name in ['linux']:
On 2015/10/31 17:22:23, John wrote:
> On 2015/10/15 23:31:41, stichnot wrote:
> > Use ('linux') like syntax above?
> 
> Because python, ('linux') means something else:
> 
>     os_name in ('l', 'i', 'n', 'u', 'x')

How about making them both of the form:

  for os_name in ['linux', 'mac']:

That seems to work for singletons as well as multiples.

[John, 2015-10-31 19:06:42]

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
File toolchain_build/toolchain_build_pnacl.py (right):

https://codereview.chromium.org/1412503002/diff/1/toolchain_build/toolchain_b...
toolchain_build/toolchain_build_pnacl.py:1150: for os_name in ['linux']:
On 2015/10/31 17:41:31, stichnot wrote:
> On 2015/10/31 17:22:23, John wrote:
> > On 2015/10/15 23:31:41, stichnot wrote:
> > > Use ('linux') like syntax above?
> > 
> > Because python, ('linux') means something else:
> > 
> >     os_name in ('l', 'i', 'n', 'u', 'x')
> 
> How about making them both of the form:
> 
>   for os_name in ['linux', 'mac']:
> 
> That seems to work for singletons as well as multiples.

Done.

[Jim Stichnoth, 2015-10-31 19:54:34]

lgtm

[Jim Stichnoth, 2015-11-01 00:59:18]

The CQ bit was checked by stichnot@chromium.org

[commit-bot: I haz the power, 2015-11-01 00:59:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412503002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412503002/80001

[commit-bot: I haz the power, 2015-11-01 01:34:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/native_client/src/native_client/+/e9ffd89a1...