PNaCl. Enables Unsandboxed nonsfi ARM32.

toolchain_build/toolchain_build_pnacl.py

 #!/usr/bin/python
 # Copyright (c) 2013 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Recipes for PNaCl toolchain packages.
 
    Recipes consist of specially-structured dictionaries, with keys for package
    name, type, commands to execute, etc. The structure is documented in the
    PackageBuilder docstring in toolchain_main.py.
@@ skipping 1129 matching lines @@
          'binutils_x86_%s' % legal_triple,
          'llvm_%s' % legal_triple,
          'driver_%s' % legal_triple])
     if os_name != 'win':
       host_packages[os_name].append('libcxx_%s' % legal_triple)
 
   # Unsandboxed target IRT libraries
   for os_name in ('linux', 'mac'):
     legal_triple = pynacl.gsd_storage.LegalizeName('x86-32-' + os_name)
     host_packages[os_name].append('unsandboxed_runtime_%s' % legal_triple)
+  for os_name in ['linux']:

[Jim Stichnoth, 2015/10/15 23:31:41]

Use ('linux') like syntax above?

[John, 2015/10/31 17:22:23]

Because python, ('linux') means something else:

    os_name in ('l', 'i', 'n', 'u', 'x')

[Jim Stichnoth, 2015/10/31 17:41:31]

How about making them both of the form:

  for os_name in ['linux', 'mac']:

That seems to work for singletons as well as multiples.

[John, 2015/10/31 19:06:42]

Done.

+    legal_triple = pynacl.gsd_storage.LegalizeName('arm-' + os_name)
+    host_packages[os_name].append('unsandboxed_runtime_%s' % legal_triple)
 
   for os_name, os_packages in host_packages.iteritems():
     package_target = '%s_x86' % pynacl.platform.GetOS(os_name)
     package_targets[package_target] = {}
 
     raw_packages = os_packages + common_raw_packages
     package_targets[package_target]['pnacl_newlib_raw'] = raw_packages
 
     complete_packages = raw_packages + common_complete_packages
     package_targets[package_target]['pnacl_newlib'] = complete_packages
@@ skipping 112 matching lines @@
     for arch in TRANSLATOR_ARCHES:
       packages.update(pnacl_targetlibs.TranslatorLibs(arch, is_canonical,
         args.no_nacl_gcc))
     packages.update(Metadata(rev, is_canonical))
     packages.update(pnacl_targetlibs.SDKCompiler(
                     ['le32'] + DIRECT_TO_NACL_ARCHES))
     packages.update(pnacl_targetlibs.SDKLibs('le32', is_canonical))
     unsandboxed_runtime_canonical = is_canonical or pynacl.platform.IsMac()
     packages.update(pnacl_targetlibs.UnsandboxedRuntime(
         'x86-32-%s' % pynacl.platform.GetOS(), unsandboxed_runtime_canonical))
+    packages.update(pnacl_targetlibs.UnsandboxedRuntime(
+        'arm-%s' % pynacl.platform.GetOS(), unsandboxed_runtime_canonical))
 
   if args.build_sbtc and not args.pnacl_in_pnacl:
     packages.update(pnacl_sandboxed_translator.SandboxedTranslators(
       SANDBOXED_TRANSLATOR_ARCHES))
 
   tb = toolchain_main.PackageBuilder(packages,
                                      upload_packages,
                                      leftover_args)
   return tb.Main()
 
 
 if __name__ == '__main__':
   sys.exit(main())