Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7811)

Unified Diff: chrome/common/extensions/docs/server2/patch_servlet.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/
Patch Set: everything but patch_servlet Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/patch_servlet.py
===================================================================
--- chrome/common/extensions/docs/server2/patch_servlet.py (revision 0)
+++ chrome/common/extensions/docs/server2/patch_servlet.py (revision 0)
@@ -0,0 +1,95 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from appengine_url_fetcher import AppEngineUrlFetcher
+from caching_file_system import CachingFileSystem
+from caching_rietveld_patcher import CachingRietveldPatcher
+from chained_compiled_file_system import (CompiledFileSystem,
not at google - send to devlin 2013/05/12 03:28:27 CompiledFIleSystem?
方觉(Fang Jue) 2013/05/12 04:22:07 oh, sorry.
+ ChainedCompiledFileSystem)
+from instance_servlet import InstanceServlet
+from render_servlet import RenderServlet
+from rietveld_patcher import RietveldPatcher, RietveldPatcherError
+from object_store_creator import ObjectStoreCreator
+from patched_file_system import PatchedFileSystem
+from server_instance import ServerInstance
+from servlet import Request, Response, Servlet
+import svn_constants
+import url_constants
+
+class PatchServlet(Servlet):
+ '''Servlet which renders patched docs.
+ '''
+ class Delegate(InstanceServlet.Delegate):
+ def __init__(self, issue):
+ self._issue = issue
+
+ # Overriden in test.
+ def _GetChannel(self, channel):
+ return channel
+
+ def CreateServerInstanceForChannel(self, channel):
+ channel = self._GetChannel(channel)
+ base_object_store_creator = ObjectStoreCreator(channel,
+ start_empty=False)
+ object_store_creator = ObjectStoreCreator('trunk@%s' % self._issue,
+ start_empty=False)
+ # TODO(fj): Use OfflineFileSystem here once all json/idl files in api/
+ # are pulled into data store by cron jobs.
+ base_file_system = CachingFileSystem(self.CreateHostFileSystemForBranch(
+ channel), base_object_store_creator)
+ rietveld_patcher = CachingRietveldPatcher(
+ RietveldPatcher(svn_constants.EXTENSIONS_PATH,
+ self._issue,
+ AppEngineUrlFetcher(url_constants.CODEREVIEW_SERVER)),
+ object_store_creator)
+ patched_file_system = PatchedFileSystem(base_file_system,
+ rietveld_patcher)
+ base_compiled_fs_factory = CompiledFileSystem.Factory(
+ base_file_system, base_object_store_creator)
+ patched_compiled_fs_factory = CompiledFileSystem.Factory(
+ patched_file_system, object_store_creator)
+ compiled_fs_factory = ChainedCompiledFileSystem.Factory(
+ [patched_compiled_fs_factory, base_compiled_fs_factory])
+ return ServerInstance(channel,
+ object_store_creator,
+ patched_file_system,
+ self.CreateAppSamplesFileSystem(
+ object_store_creator),
+ '/_patch/%s/static' % self._issue,
+ compiled_fs_factory)
+
+ def __init__(self, request, delegate=None):
+ self._request = request
+ self._delegate = delegate
+
+ def Get(self):
+ path_with_issue = self._request.path.lstrip('/')
+ if '/' in path_with_issue:
+ issue, real_path = path_with_issue.split('/', 1)
+ else:
+ return Response.NotFound('Malformed URL. It should look like ' +
+ 'https://developer.chrome.com/_patch/12345/extensions/...')
+
+ fake_path = '/trunk/%s' % real_path
+
+ if self._delegate is None:
+ self._delegate = PatchServlet.Delegate(issue)
+
+ try:
+ response = RenderServlet(Request(fake_path,
+ self._request.host,
+ self._request.headers),
+ self._delegate).Get()
+ # Disable cache for patched content.
+ response.headers.pop('cache-control', None)
+ except RietveldPatcherError as e:
+ response = Response.NotFound(e.message, {'Content-Type': 'text/plain'})
+
+ redirect_url, permanent = response.GetRedirect()
+ if redirect_url is not None:
+ if redirect_url.startswith('/trunk/'):
+ redirect_url = redirect_url.split('/trunk', 1)[1]
+ response = Response.Redirect('/_patch/%s%s' % (issue, redirect_url),
+ permanent)
+ return response
Property changes on: chrome/common/extensions/docs/server2/patch_servlet.py
___________________________________________________________________
Added: svn:eol-style
+ LF

Powered by Google App Engine
This is Rietveld 408576698