Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/common/extensions/docs/server2/patch_servlet.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/
Patch Set: everything but patch_servlet Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
Property Changes:
Added: svn:eol-style
+ LF
OLDNEW
(Empty)
1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 from appengine_url_fetcher import AppEngineUrlFetcher
6 from caching_file_system import CachingFileSystem
7 from caching_rietveld_patcher import CachingRietveldPatcher
8 from chained_compiled_file_system import (CompiledFileSystem,
not at google - send to devlin 2013/05/12 03:28:27 CompiledFIleSystem?
方觉(Fang Jue) 2013/05/12 04:22:07 oh, sorry.
9 ChainedCompiledFileSystem)
10 from instance_servlet import InstanceServlet
11 from render_servlet import RenderServlet
12 from rietveld_patcher import RietveldPatcher, RietveldPatcherError
13 from object_store_creator import ObjectStoreCreator
14 from patched_file_system import PatchedFileSystem
15 from server_instance import ServerInstance
16 from servlet import Request, Response, Servlet
17 import svn_constants
18 import url_constants
19
20 class PatchServlet(Servlet):
21 '''Servlet which renders patched docs.
22 '''
23 class Delegate(InstanceServlet.Delegate):
24 def __init__(self, issue):
25 self._issue = issue
26
27 # Overriden in test.
28 def _GetChannel(self, channel):
29 return channel
30
31 def CreateServerInstanceForChannel(self, channel):
32 channel = self._GetChannel(channel)
33 base_object_store_creator = ObjectStoreCreator(channel,
34 start_empty=False)
35 object_store_creator = ObjectStoreCreator('trunk@%s' % self._issue,
36 start_empty=False)
37 # TODO(fj): Use OfflineFileSystem here once all json/idl files in api/
38 # are pulled into data store by cron jobs.
39 base_file_system = CachingFileSystem(self.CreateHostFileSystemForBranch(
40 channel), base_object_store_creator)
41 rietveld_patcher = CachingRietveldPatcher(
42 RietveldPatcher(svn_constants.EXTENSIONS_PATH,
43 self._issue,
44 AppEngineUrlFetcher(url_constants.CODEREVIEW_SERVER)),
45 object_store_creator)
46 patched_file_system = PatchedFileSystem(base_file_system,
47 rietveld_patcher)
48 base_compiled_fs_factory = CompiledFileSystem.Factory(
49 base_file_system, base_object_store_creator)
50 patched_compiled_fs_factory = CompiledFileSystem.Factory(
51 patched_file_system, object_store_creator)
52 compiled_fs_factory = ChainedCompiledFileSystem.Factory(
53 [patched_compiled_fs_factory, base_compiled_fs_factory])
54 return ServerInstance(channel,
55 object_store_creator,
56 patched_file_system,
57 self.CreateAppSamplesFileSystem(
58 object_store_creator),
59 '/_patch/%s/static' % self._issue,
60 compiled_fs_factory)
61
62 def __init__(self, request, delegate=None):
63 self._request = request
64 self._delegate = delegate
65
66 def Get(self):
67 path_with_issue = self._request.path.lstrip('/')
68 if '/' in path_with_issue:
69 issue, real_path = path_with_issue.split('/', 1)
70 else:
71 return Response.NotFound('Malformed URL. It should look like ' +
72 'https://developer.chrome.com/_patch/12345/extensions/...')
73
74 fake_path = '/trunk/%s' % real_path
75
76 if self._delegate is None:
77 self._delegate = PatchServlet.Delegate(issue)
78
79 try:
80 response = RenderServlet(Request(fake_path,
81 self._request.host,
82 self._request.headers),
83 self._delegate).Get()
84 # Disable cache for patched content.
85 response.headers.pop('cache-control', None)
86 except RietveldPatcherError as e:
87 response = Response.NotFound(e.message, {'Content-Type': 'text/plain'})
88
89 redirect_url, permanent = response.GetRedirect()
90 if redirect_url is not None:
91 if redirect_url.startswith('/trunk/'):
92 redirect_url = redirect_url.split('/trunk', 1)[1]
93 response = Response.Redirect('/_patch/%s%s' % (issue, redirect_url),
94 permanent)
95 return response
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698