Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1412443003: [turbofan] Introduce lazy bailout, masked as a call. (Closed)

Created:
5 years, 2 months ago by Jarin
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce lazy bailout, masked as a call. This introduces an explicit lazy bailout. It is wrapped in the call node, mostly because the lazy deoptimization processing is married to the call processing in the instruction selector and the code generator. It is still a terrible hack. R=bmeurer@chromium.org,mstarzinger@chromium.org BUG=chromium:543994, v8:4195 LOG=n Committed: https://crrev.com/f9a9c6be0ebcfaf42159b4083d66e9ec7ab9d0af Cr-Commit-Position: refs/heads/master@{#31353}

Patch Set 1 #

Patch Set 2 : Add comment #

Total comments: 2

Patch Set 3 : Platform ports, address review comments. #

Patch Set 4 : Remove duplicate case #

Patch Set 5 : Test #

Patch Set 6 : Use the operator zone for the call descriptor #

Patch Set 7 : Attempt to make gcc happy. #

Patch Set 8 : Enable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -55 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 2 chunks +14 lines, -8 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/linkage.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-543994.js View 1 2 3 4 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
LGTM on the AstGraphBuilder with comments, didn't look at the rest. https://codereview.chromium.org/1412443003/diff/20001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (left): ...
5 years, 2 months ago (2015-10-16 13:25:08 UTC) #2
Jarin
Benedikt, could you take a look, please?
5 years, 2 months ago (2015-10-16 14:12:58 UTC) #4
Michael Starzinger
Also, could you try to re-enable regress/regress-crbug-450960 in the mjsunit.status file. I think that failure ...
5 years, 2 months ago (2015-10-16 15:59:44 UTC) #5
Benedikt Meurer
This is indeed an awful hack, but staring at this CL, I think it improves ...
5 years, 2 months ago (2015-10-19 04:27:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412443003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412443003/140001
5 years, 2 months ago (2015-10-19 05:58:53 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 2 months ago (2015-10-19 06:21:11 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 06:21:36 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/f9a9c6be0ebcfaf42159b4083d66e9ec7ab9d0af
Cr-Commit-Position: refs/heads/master@{#31353}

Powered by Google App Engine
This is Rietveld 408576698