third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp - Issue 1412433004: bindings: Generation of dictionary IDLs with RuntimeEnabled attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

Issue 1412433004: bindings: Generation of dictionary IDLs with RuntimeEnabled attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_dictionary.py ('k') | third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

index 823124424dd837482101e8ebbf17e64d6cf2d756..a4f38c42865db07735e7af37a78d6fd6d6a11666 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

@@ -40,7 +40,11 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{

}

{% endif %}

{% for member in members %}

+ {% if member.runtime_enabled_function %}

+ if ({{member.runtime_enabled_function}}()) {

+ {% else %}

{

+ {% endif %}

v8::Local<v8::Value> {{member.name}}Value;

if (!v8Object->Get(isolate->GetCurrentContext(), v8String(isolate, "{{member.name}}")).ToLocal(&{{member.name}}Value)) {

exceptionState.rethrowV8Exception(block.Exception());