Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1412423013: Remove a couple of unused variables. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove a couple of unused variables. -Wunused-variable triggers for PODs, but not for CFX_WideString. R=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3388f907ecac9e7662bca3bbfdf35721ded19f26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
Clang WAI?
5 years, 1 month ago (2015-11-07 01:07:17 UTC) #2
Nico
lgtm Yeah that's WAI, else it'd warn on all the AutoLocks…
5 years, 1 month ago (2015-11-07 01:08:10 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-09 22:08:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3388f907ecac9e7662bca3bbfdf35721ded19f26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698