fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp - Issue 1412423013: Remove a couple of unused variables.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

Issue 1412423013: Remove a couple of unused variables. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 PDFium Authors. All rights reserved.	1 // Copyright 2015 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "../../../testing/embedder_test.h"	5 #include "../../../testing/embedder_test.h"

6 #include "../../include/jsapi/fxjs_v8.h"	6 #include "../../include/jsapi/fxjs_v8.h"

7 #include "core/include/fpdfapi/fpdf_parser.h"	7 #include "core/include/fpdfapi/fpdf_parser.h"

8 #include "testing/gtest/include/gtest/gtest.h"	8 #include "testing/gtest/include/gtest/gtest.h"

9 #include "third_party/base/nonstd_unique_ptr.h"	9 #include "third_party/base/nonstd_unique_ptr.h"

10	10

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 v8::Isolate* m_pIsolate;	52 v8::Isolate* m_pIsolate;

53 v8::Global<v8::Context> m_pPersistentContext;	53 v8::Global<v8::Context> m_pPersistentContext;

54 };	54 };

55	55

56 TEST_F(FXJSV8Embeddertest, Getters) {	56 TEST_F(FXJSV8Embeddertest, Getters) {

57 v8::Isolate::Scope isolate_scope(isolate());	57 v8::Isolate::Scope isolate_scope(isolate());

58 v8::HandleScope handle_scope(isolate());	58 v8::HandleScope handle_scope(isolate());

59 v8::Context::Scope context_scope(GetV8Context());	59 v8::Context::Scope context_scope(GetV8Context());

60	60

61 FXJSErr error;	61 FXJSErr error;

62 CFX_WideString wsInfo;

63 CFX_WideString wsScript(kScript);

64 int sts = FXJS_Execute(isolate(), nullptr, kScript, &error);	62 int sts = FXJS_Execute(isolate(), nullptr, kScript, &error);

65 EXPECT_EQ(0, sts);	63 EXPECT_EQ(0, sts);

66	64

67 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());	65 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());

68 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");	66 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");

69 EXPECT_TRUE(fred->IsNumber());	67 EXPECT_TRUE(fred->IsNumber());

70 }	68 }

OLD	NEW