WebRTC: Add Linux GCC bot.

WebRTC: Add Linux GCC bot.

This should make it easier for us to discover and fix GCC specific
compilation issues (that today only surface on Android).

BUG=webrtc:2365
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297196

[kjellander_chromium, 2015-10-19 21:43:19]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 21:43:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412353002/1

[kjellander_chromium, 2015-10-19 21:44:26]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 21:44:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412353002/20001

[kjellander_chromium, 2015-10-19 21:48:58]

kjellander@chromium.org changed reviewers:
+ machenbach@chromium.org

[kjellander_chromium, 2015-10-19 21:48:59]

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipes/w...
File
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json
(right):

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipes/w...
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json:95:
"goma",
I noticed V8 uses make and local compile instead of Goma, but AFAICT Goma is
still supporting GCC so that shouldn't 'be a problem.

[commit-bot: I haz the power, 2015-10-19 21:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 21:51:48]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2015-10-20 06:54:19]

lgtm ~ missing owner lgtm for chromium module.

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:285: @config_ctx()
If you put it into this file, maybe add group='compiler' for consistency
reasons? We never added group constraints in v8 - they always gave us trouble
when inheriting things that already had group constraints - so I'm not sure if
it's going to work.

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipes/w...
File
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json
(right):

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipes/w...
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json:95:
"goma",
On 2015/10/19 21:48:59, kjellander (chromium) wrote:
> I noticed V8 uses make and local compile instead of Goma, but AFAICT Goma is
> still supporting GCC so that shouldn't 'be a problem.

Yes, it should be supported. I think it's because we miss the necessary logic in
our standalone gyp files. It's only 2-3 lines of code but I didn't get to it
yet...

[kjellander_chromium, 2015-10-20 07:41:31]

Description was changed from

==========
WebRTC: Add Linux GCC bot.

BUG=
==========

to

==========
WebRTC: Add Linux GCC bot.

BUG=
==========

[kjellander_chromium, 2015-10-20 07:41:31]

kjellander@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[kjellander_chromium, 2015-10-20 07:43:23]

Pawel, can you have a look at this? 

I also renamed no_clang --> gcc in PS#3, since I think it makes more sense (even
if it's just setting clang=0 that's more like an "implementation detail" IMO)

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:285: @config_ctx()
On 2015/10/20 06:54:18, Michael Achenbach wrote:
> If you put it into this file, maybe add group='compiler' for consistency
> reasons? We never added group constraints in v8 - they always gave us trouble
> when inheriting things that already had group constraints - so I'm not sure if
> it's going to work.

I tried but then it failed with:
BadConf: "no_clang" is a member of group "compiler", but ('default_compiler',)
already ran
using the current setup of configs.
I updated this in PS#3 and added Pawel to leave his opinion on how we should do.
I could also add a chromium_gcc config, but I'm not sure it makes sense since
there's no Chromium GCC bot.

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipes/w...
File
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json
(right):

https://codereview.chromium.org/1412353002/diff/20001/scripts/slave/recipes/w...
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json:95:
"goma",
On 2015/10/20 06:54:19, Michael Achenbach wrote:
> On 2015/10/19 21:48:59, kjellander (chromium) wrote:
> > I noticed V8 uses make and local compile instead of Goma, but AFAICT Goma is
> > still supporting GCC so that shouldn't 'be a problem.
> 
> Yes, it should be supported. I think it's because we miss the necessary logic
in
> our standalone gyp files. It's only 2-3 lines of code but I didn't get to it
> yet...

Acknowledged.

[Paweł Hajdan Jr., 2015-10-20 10:09:55]

LGTM

[kjellander_chromium, 2015-10-20 11:09:22]

On 2015/10/20 10:09:55, Paweł Hajdan Jr. wrote:
> LGTM

Michael: still ok with you with the rename of the config? (no_clang -> gcc)

[Michael Achenbach, 2015-10-20 11:12:52]

lgtm

[kjellander_chromium, 2015-10-20 11:18:52]

Description was changed from

==========
WebRTC: Add Linux GCC bot.

BUG=
==========

to

==========
WebRTC: Add Linux GCC bot.

This should make it easier for us to discover and fix GCC specific
compilation issues (that today only surface on Android).

BUG=webrtc:2365
==========

[kjellander_chromium, 2015-10-20 11:19:00]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2015-10-20 11:19:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412353002/40001

[commit-bot: I haz the power, 2015-10-20 11:22:04]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297196